Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: support debugCall on arm64 #50614

Closed
aarzilli opened this issue Jan 14, 2022 · 25 comments
Closed

runtime: support debugCall on arm64 #50614

aarzilli opened this issue Jan 14, 2022 · 25 comments
Labels
arch-arm64 FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@aarzilli
Copy link
Contributor

aarzilli commented Jan 14, 2022

debugCall is currently only supported on amd64, with the release of arm64 based macs it would be nice if a version of it also existed on arm64 and the feature has been requested on Delve's issue tracker: go-delve/delve#2277.

For example my message pointing out go1.18 will not support it received 25 sadfaces.

cc @heschi

@seankhliao seankhliao added arch-arm64 FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jan 16, 2022
@erifan
Copy link
Contributor

erifan commented Jan 17, 2022

I'll take a look, assign it to me for now, if anyone makes a patch before me, feel free to submit it. Thanks.

@erifan erifan self-assigned this Jan 17, 2022
@mjaniko
Copy link

mjaniko commented Jan 31, 2022

The issue is still open

@amjd
Copy link

amjd commented Feb 8, 2022

Is this definitely not going to be included in go1.18, or is there a small chance it might?

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Feb 8, 2022

I don't see any implementation yet, so it will definitely not be in Go 1.18. Sorry.

@amjd
Copy link

amjd commented Feb 9, 2022

No problem, thanks for confirming @ianlancetaylor. Hope this gets implemented and is released with Go 1.19.

@gopherbot
Copy link

gopherbot commented Mar 25, 2022

Change https://go.dev/cl/395754 mentions this issue: runtime: support for debugger function calls on linux/arm64

@erifan
Copy link
Contributor

erifan commented Mar 25, 2022

I have sent the PR, hope it will be merged into go1.19.

@AlekSi
Copy link
Contributor

AlekSi commented Mar 25, 2022

That CL is only for linux/arm64, not for darwin/arm64, right?

@erifan
Copy link
Contributor

erifan commented Mar 25, 2022

Yes, X86 also currently supports Linux only.

@amjd
Copy link

amjd commented Mar 25, 2022

Anyone planning to work on it for darwin/arm64? // @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Mar 25, 2022

I'm not too familiar with debugCall, but what makes it Linux only?

@aarzilli
Copy link
Contributor Author

aarzilli commented Mar 25, 2022

AFAIK nothing.

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Mar 25, 2022

Let me rephrase: as far as I can see it should work on macOS/amd64 today. Is that not the case? If so, why doesn't it work? Thanks.

@aarzilli
Copy link
Contributor Author

aarzilli commented Mar 25, 2022

I should have been less curt. As far as I know it works on macOS, today, as it is. It is not true that it is linux-only.

@ianlancetaylor
Copy link
Contributor

ianlancetaylor commented Mar 25, 2022

Great, thanks.

@erifan
Copy link
Contributor

erifan commented Mar 26, 2022

Sorry I just stared at the test, the test only supports Linux, but the implementation should not be limited to the system.

@chenzhiguo
Copy link

chenzhiguo commented Apr 7, 2022

Does Apple M1 (Pro, Max) will be supported?

@ncomet
Copy link

ncomet commented Apr 7, 2022

Does Apple M1 (Pro, Max) will be supported?

From the discussions above, yes. It should be covered.

@ms140569
Copy link

ms140569 commented Apr 28, 2022

This issue is still not solved on the Latest Mac OS X version:

Mac OSX: 12.3.1 (21E258)

Darwin FVFGT4PMQ05N 21.4.0 Darwin Kernel Version 21.4.0: Fri Mar 18 00:47:26 PDT 2022; root:xnu-8020.101.4~15/RELEASE_ARM64_T8101 arm64

go version go1.18.1 darwin/arm64

Delve Debugger
Version: 1.8.3
Build: $Id: f92bb46b82b3b92d79ce59c4b55eeefbdd8d040c $

@aarzilli
Copy link
Contributor Author

aarzilli commented Apr 28, 2022

@ms140569 this issue is about implementing the runtime's side of call injection, which did happen. It will not work until delve's side is also implemented.

@amjd
Copy link

amjd commented Apr 28, 2022

Even if this is implemented, the changes won't be live until go1.19, right? Or is there a chance these could be included in a minor version?

@tinyfluffs
Copy link

tinyfluffs commented May 4, 2022

@gopherbot please open backports for Go 1.18

@gopherbot
Copy link

gopherbot commented May 4, 2022

Backport issue(s) opened: #52699 (for 1.18).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@aclements
Copy link
Member

aclements commented May 4, 2022

@erifan , would you mind preparing a backport CL to release-branch.go.1.18 to resolve #52699?

@erifan
Copy link
Contributor

erifan commented May 5, 2022

Sure, I'd happy to.

@rsc rsc unassigned erifan Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-arm64 FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests