Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math/big: Rat.SetString may consume large amount of RAM and crash [1.16 backport] #50700

Closed
gopherbot opened this issue Jan 19, 2022 · 3 comments
Closed

math/big: Rat.SetString may consume large amount of RAM and crash [1.16 backport] #50700

gopherbot opened this issue Jan 19, 2022 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Security
Milestone
Go1.16.14

Comments

@gopherbot
Copy link
Contributor

@katiehockman requested issue #50699 to be considered for backport to the next 1.16 minor release.

@gopherbot please backport to 1.17 and 1.16 as this is a security issue.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 19, 2022
@gopherbot gopherbot mentioned this issue Jan 19, 2022
Closed
@gopherbot gopherbot added this to the Go1.16.14 milestone Jan 19, 2022
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/381337 mentions this issue: [release-branch.go1.16] math/big: prevent overflow in (*Rat).SetString

@dmitshur dmitshur mentioned this issue Jan 28, 2022
Closed
@dmitshur
Copy link
Contributor

Approving as a fix to a security issue. This backport applies to both 1.17 (#50701) and 1.16 (this issue).

@dmitshur dmitshur added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Jan 28, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 07ee9e6 to release-branch.go1.16.

gopherbot pushed a commit that referenced this issue Jan 28, 2022
@katiehockman
[release-branch.go1.16] math/big: prevent overflow in (*Rat).SetString
07ee9e6 
Credit to rsc@ for the original patch.

Thanks to the OSS-Fuzz project for discovering this
issue and to Emmanuel Odeke (@odeke_et) for reporting it.

Updates #50699
Fixes #50700
Fixes CVE-2022-23772

Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
(cherry picked from commit ad345c2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381337
danbudris pushed a commit to danbudris/go that referenced this issue Sep 14, 2022
@katiehockman @danbudris
[release-branch.go1.16] math/big: prevent overflow in (*Rat).SetString
f56e2b4 
Credit to rsc@ for the original patch.

Thanks to the OSS-Fuzz project for discovering this
issue and to Emmanuel Odeke (@odeke_et) for reporting it.

Updates golang#50699
Fixes golang#50700
Fixes CVE-2022-23772

Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
(cherry picked from commit ad345c2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381337
rcrozean pushed a commit to rcrozean/go that referenced this issue Oct 5, 2022
@katiehockman @rcrozean
math/big: prevent overflow in (*Rat).SetString
0128f8e 
# AWS EKS
Backported To: go-1.15.15-eks
Backported On: Thu, 22 Sept 2022
Backported By: budris@amazon.com
Backported From: release-branch.go1.16
Upstream Source Commit: golang@07ee9e6
EKS Patch Source Commit: danbudris@f56e2b4

# Original Information

Credit to rsc@ for the original patch.

Thanks to the OSS-Fuzz project for discovering this
issue and to Emmanuel Odeke (@odeke_et) for reporting it.

Updates golang#50699
Fixes golang#50700
Fixes CVE-2022-23772

Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
(cherry picked from commit ad345c2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381337
rcrozean pushed a commit to rcrozean/go that referenced this issue Oct 12, 2022
@katiehockman @rcrozean
math/big: prevent overflow in (*Rat).SetString
afa120a 
# AWS EKS
Backported To: go-1.15.15-eks
Backported On: Thu, 22 Sept 2022
Backported By: budris@amazon.com
Backported From: release-branch.go1.16
Upstream Source Commit: golang@07ee9e6
EKS Patch Source Commit: danbudris@f56e2b4

# Original Information

Credit to rsc@ for the original patch.

Thanks to the OSS-Fuzz project for discovering this
issue and to Emmanuel Odeke (@odeke_et) for reporting it.

Updates golang#50699
Fixes golang#50700
Fixes CVE-2022-23772

Change-Id: I590395a3d55689625390cf1e58f5f40623b26ee5
Reviewed-on: https://go-review.googlesource.com/c/go/+/379537
Trust: Katie Hockman <katie@golang.org>
Run-TryBot: Katie Hockman <katie@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
Reviewed-by: Roland Shoemaker <roland@golang.org>
Reviewed-by: Julie Qiu <julie@golang.org>
(cherry picked from commit ad345c2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/381337
@golang golang locked and limited conversation to collaborators Jan 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker Security
Projects
None yet
Milestone
Go1.16.14
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @katiehockman