Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/lsp/lsprpc: TestClientLoggingV2 failure with "timeout waiting for client log" #50724

Open
bcmills opened this issue Jan 20, 2022 · 3 comments
Open

x/tools/internal/lsp/lsprpc: TestClientLoggingV2 failure with "timeout waiting for client log" #50724

bcmills opened this issue Jan 20, 2022 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/later

Comments

@bcmills
Copy link
Member

bcmills commented Jan 20, 2022 

2022/01/20 18:03:54 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-arm64-dmgk/tmp/go-build3210943659/b793/lsprpc.test"
	client_id="3"
2022/01/20 18:03:54 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:58365->127.0.0.1:25447: use of closed network connection
2022/01/20 18:03:55 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir-host-freebsd-arm64-dmgk/tmp/go-build3210943659/b793/lsprpc.test"
	client_id="6"
2022/01/20 18:03:57 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:25208->127.0.0.1:60842: use of closed network connection
2022/01/20 18:03:57 ping
2022/01/20 18:03:58 jsonrpc2 message delivery failed: JSON RPC internal error: "window/logMessage" notification failed: io: read/write on closed pipe: JSON RPC internal error
2022/01/20 18:03:58 ping
--- FAIL: TestClientLoggingV2 (1.58s)
    --- FAIL: TestClientLoggingV2/forwarded (1.58s)
        binder_test.go:111: timeout waiting for client log
FAIL
FAIL	golang.org/x/tools/internal/lsp/lsprpc	5.125s

greplogs --dashboard -md -l -e 'timeout waiting for client log' --since=2021-01-01

2022-01-20T14:52:25-ab35822-9de1ac6/freebsd-arm64-dmgk

CC @findleyr
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 20, 2022
@gopherbot gopherbot added this to the Unreleased milestone Jan 20, 2022
@findleyr findleyr modified the milestones: Unreleased, gopls/on-deck Jan 20, 2022
@bcmills
Copy link
Member Author

bcmills commented Feb 4, 2022

Now that the freebsd-amd64-race builder is back, it caught one too. Looks like the same failure mode, and it's a scalable builder (so might be easier to reproduce with a gomote).

greplogs --dashboard -md -l -e 'timeout waiting for client log' --since=2022-01-21

2022-02-04T14:03:20-8305295-1b867ce/freebsd-amd64-race

2022/02/04 14:11:02 New server
	new_server="1"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build2798088286/b793/lsprpc.test"
	client_id="3"
2022/02/04 14:11:02 forwarder: exited with error: remote disconnected: failed reading header line: read tcp 127.0.0.1:53063->127.0.0.1:14348: use of closed network connection
2022/02/04 14:11:05 New server
	new_server="3"
	logfile=""
	debug_address=""
	gopls_path="/tmp/workdir/tmp/go-build2798088286/b793/lsprpc.test"
	client_id="6"
2022/02/04 14:11:06 forwarder: exited with error: client disconnected: io: read/write on closed pipe
2022/02/04 14:11:06 ping
2022/02/04 14:11:08 ping
--- FAIL: TestClientLoggingV2 (1.31s)
    --- FAIL: TestClientLoggingV2/forwarded (1.29s)
        binder_test.go:111: timeout waiting for client log
2022/02/04 14:11:08 jsonrpc2 message delivery failed: io: read/write on closed pipe
2022/02/04 14:11:08 jsonrpc2 message delivery failed: io: read/write on closed pipe
FAIL
FAIL	golang.org/x/tools/internal/lsp/lsprpc	5.853s

@findleyr findleyr added Testing An issue that has been verified to require only test changes, not just a test failure. and removed gopls/testing labels May 10, 2022
@heschi
Copy link
Contributor

heschi commented Jul 6, 2022

2022-07-01T14:51:09-f042799-8d2935a/freebsd-amd64-race

@bcmills
Copy link
Member Author

bcmills commented Aug 22, 2022

2022-08-04T18:51:46-99fd76f-a10afb1/freebsd-amd64-race

@bcmills bcmills mentioned this issue Aug 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/later
Development

No branches or pull requests
4 participants
@bcmills @gopherbot @heschi @findleyr