Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: Test{Read,Write}TimeoutFluctuation failures on BSD variants #50725

Open
bcmills opened this issue Jan 20, 2022 · 4 comments
Open

os: Test{Read,Write}TimeoutFluctuation failures on BSD variants #50725

bcmills opened this issue Jan 20, 2022 · 4 comments
Labels
NeedsInvestigation
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Jan 20, 2022

--- FAIL: TestReadTimeoutFluctuation (1.04s)
    timeout_test.go:272: Read took over 1s; expected 0.1s
--- FAIL: TestWriteTimeoutFluctuation (1.06s)
    timeout_test.go:324: Write took over 1s; expected 0.1s
FAIL
FAIL	os	1.975s

greplogs --dashboard -md -l -e '(?ms)FAIL: Test(?:Read|Write)TimeoutFluctuation.*FAIL\s+os\s' --since=2021-01-01

2022-01-18T23:59:40-50869f3/dragonfly-amd64
2021-11-18T06:05:29-f6647f2/freebsd-arm-paulzhol
2021-11-03T00:07:03-d6f7203/dragonfly-amd64
2021-09-24T14:52:47-217507e/netbsd-arm-bsiegert
2021-09-21T20:28:50-2fc7df9/dragonfly-amd64
2021-04-16T01:54:27-f08c552/dragonfly-amd64-5_8

This may or may not be related in some way to #50189.

The most frequent recent failures are on dragonfly-amd64 (CC @tuxillo). A good first step might be to change the test to panic instead of calling t.Errorf or t.Fatalf: a panic would at least dump any goroutines that are stuck so that we can see which goroutines and/or system calls are still in flight at the time of failure.

@bcmills bcmills added the NeedsInvestigation label Jan 20, 2022
@bcmills bcmills added this to the Go1.19 milestone Jan 20, 2022
@bcmills
Copy link
Member Author

@bcmills bcmills commented May 9, 2022

greplogs -l -e '(?ms)FAIL: Test(?:Read|Write)TimeoutFluctuation.*FAIL\s+os\s' --since=2022-01-19
2022-05-06T17:41:30-091e913/dragonfly-amd64

@tuxillo
Copy link
Contributor

@tuxillo tuxillo commented May 9, 2022

Any action to be taken on my side?

@bcmills
Copy link
Member Author

@bcmills bcmills commented May 9, 2022

I still think changing the test to panic would be a good first step — it would be nice to know what the test is blocked on when it fails!

@tuxillo
Copy link
Contributor

@tuxillo tuxillo commented May 9, 2022

Okay, let me know if we need to check anything OS specific on our side :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

2 participants