Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: print instantiated types with package qualification in type cycles spanning external packages #50788

Open
griesemer opened this issue Jan 24, 2022 · 0 comments
Assignees
Labels
NeedsFix
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Jan 24, 2022

This is a reminder issue to fix the printing of external instantiated packages (as reported with cycle errors) that contribute to invalid type cycles. Add corresponding tests.

See Checker.validType implementation, when we call check.cycleError(path[i:]) for a cycle that spans important instantiated types.

cc: @findleyr

@griesemer griesemer added the NeedsFix label Jan 24, 2022
@griesemer griesemer added this to the Go1.19 milestone Jan 24, 2022
@griesemer griesemer self-assigned this Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
None yet
Development

No branches or pull requests

1 participant