Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: log.showSignature=true in .gitconfig breaks VCS stamping #50789

Closed
dpifke opened this issue Jan 24, 2022 · 5 comments
Closed

cmd/go: log.showSignature=true in .gitconfig breaks VCS stamping #50789

dpifke opened this issue Jan 24, 2022 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@dpifke
Copy link
Contributor

dpifke commented Jan 24, 2022

What version of Go are you using (go version)?

$ go version
go version go1.18beta1 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/dave/.cache/go-build"
GOENV="/home/dave/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/dave/Source/Go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/dave/Source/Go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.18"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.18/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18beta1"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/usr/share/go-1.18/src/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3850153072=/tmp/go-build -gno-record-gcc-switches"

What did you do?

$ go install
error obtaining VCS status: unrecognized VCS tool output: strconv.ParseInt: parsing " Signature made Fri 28 Feb 2020 07:31:38 AM MST\ngpg:                using RSA key 4AEE18F83AFDEB23\ngpg: Can't check signature: No public key\n95ecdbfc0b5f3e65790c43c77874ee5357ad8a8f:1582900298": invalid syntax
        Use -buildvcs=false to disable VCS stamping.
$ git config --get log.showSignature
true
$ go install -buildvcs=false
$ echo $?
0

What did you expect to see?

Successful compilation sans -buildvcs=false flag.

Removing showSignature = true from ~/.gitconfig works around the issue.

What did you see instead?

Failed compilation.

@mpx
Copy link
Contributor

mpx commented Jan 25, 2022

This should have been fixed in b1a53ec after go1.18beta1 was released (--no-show-signature was added).

@mknyszek
Copy link
Contributor

CC @bcmills

Thanks @mpx for the reference.

@mknyszek mknyszek added this to the Go1.18 milestone Jan 25, 2022
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Jan 25, 2022
@mknyszek
Copy link
Contributor

Tentatively applying release-blocker until we understand more.

@bcmills
Copy link
Member

bcmills commented Jan 25, 2022

Since this is believed to have been fixed in https://go.dev/cl/367034 (thanks @andremarianiello!), I think there is nothing remaining to be done.

@dpifke, I'm going to close this for now but please reopen if it is not fixed as expected with gotip or the next Go 1.18 beta or RC release.

@bcmills bcmills closed this as completed Jan 25, 2022
@dpifke
Copy link
Contributor Author

dpifke commented Jan 25, 2022

Verified fixed on master, sorry for the noise.

@golang golang locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants