Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: review error messages #50954

Open
griesemer opened this issue Feb 1, 2022 · 4 comments
Open

go/types, types2: review error messages #50954

griesemer opened this issue Feb 1, 2022 · 4 comments
Assignees
Labels
NeedsFix
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Feb 1, 2022

Reminder issue.

  • In some cases the Go 1.17 compiler produced better (more detailed) error messages than go/types, types2. Fix those cases.
  • Remove the difference between compiler and type checker error messages.
  • Review general format of error messages (use of : vs ()) and normalize it.

cc: @findleyr

@griesemer griesemer added the NeedsFix label Feb 1, 2022
@griesemer griesemer added this to the Go1.19 milestone Feb 1, 2022
@griesemer griesemer self-assigned this Feb 1, 2022
@gopherbot
Copy link

@gopherbot gopherbot commented Feb 1, 2022

Change https://golang.org/cl/381968 mentions this issue: doc/go1.18: explain changes to compiler error messages

gopherbot pushed a commit that referenced this issue Feb 1, 2022
For #47694.
For #50954.

Change-Id: I3789e145d64025fe2bf787fa5d01a21832903586
Reviewed-on: https://go-review.googlesource.com/c/go/+/381968
Trust: Robert Griesemer <gri@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@OladapoAjala
Copy link

@OladapoAjala OladapoAjala commented Apr 23, 2022

@griesemer I'd like to work on this issue. Kindly assign it to me and share more resources (if any) to get me started.

@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Apr 23, 2022

Thanks, @OladapoAjala for your interest here. This is an area which we (the Go team) should address and own because it requires potential changes in the compiler's existing tests, types2, go/types, and changes to the error handling machinery (which are currently in progress), as well as determining a model for error message formats, requiring lots of communication between stakeholders.

If you want to contribute elsewhere, please look for issues labeled with "help wanted". Generally, due to ongoing development in the type checkers, those are not good areas for larger changes at the moment (smaller bug fixes are always welcome, though).

Thanks.

@OladapoAjala
Copy link

@OladapoAjala OladapoAjala commented Apr 23, 2022

@griesemer thank you for the detailed response. I'd look around for issues I can contribute to, regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix
Projects
None yet
Development

No branches or pull requests

3 participants