Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: eliminate test dependencies on cloud.google.com/go #51051

Open
bcmills opened this issue Feb 7, 2022 · 2 comments
Open

cmd/go: eliminate test dependencies on cloud.google.com/go #51051

bcmills opened this issue Feb 7, 2022 · 2 comments
Assignees
Labels
GoCommand NeedsFix Testing
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Feb 7, 2022

CL 196961 added a test that fetched a module from cloud.google.com/go.

Unfortunately, the rate of 5XX-series errors for fetches from that repo has increased substantially since around 2021-11-04, quite possibly due to the same underlying problem as #50541.

Since the cloud.google.com server isn't controlled by the Go project proper, we should probably eliminate this test dependency.
(CC @matloob)

greplogs --dashboard -md -l -e 'https://cloud\.google\.com/go.*: 5\d\d\b'

2022-02-04T23:42:58-7c9885d/linux-386-longtest
2022-01-25T00:39:08-16d6a52/linux-386-longtest
2022-01-20T19:24:26-2c2e081/linux-386-longtest
2022-01-17T09:23:25-897b3da/linux-386-longtest
2021-12-21T18:34:03-cfb0cc3/linux-amd64-longtest
2021-12-20T23:46:23-1555062/linux-amd64-longtest
2021-11-16T06:36:08-a52e4b9/linux-386-longtest
2021-11-13T02:30:25-c546052/linux-386-longtest
2021-11-04T17:07:48-5772877/linux-amd64-longtest
2021-11-04T16:59:45-6e7b82a/linux-386-longtest
2021-08-16T20:22:08-4466141/linux-386-longtest
2020-07-09T16:26:07-72735e7/linux-386-longtest

@bcmills
Copy link
Member Author

@bcmills bcmills commented Feb 7, 2022

https://build.golang.org/log/4817f8416202d679733c88b235c161ccbe8d7817 provides fairly compelling evidence that this is, in fact, related to #50541: in that log, a cloud.google.com/go fetch with a 500 error occurred in close correspondence with a go.googlesource.com fetch with a 502.

@bcmills bcmills added GoCommand NeedsFix Testing labels Feb 7, 2022
@bcmills bcmills added this to the Go1.19 milestone Feb 7, 2022
@bcmills bcmills self-assigned this Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand NeedsFix Testing
Projects
None yet
Development

No branches or pull requests

1 participant