Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types, types2: verify/correct actual types recorded for type parameter "constant" values #51093

Closed
griesemer opened this issue Feb 9, 2022 · 2 comments
Assignees
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@griesemer
Copy link
Contributor

Reminder issue.

The Info.Types map records the types and values for constant expressions.

Constant values may be representable by a type parameter, but constants cannot have type parameter type. Instead, the constant is converted into a non-constant of type parameter type. Verify that we see the expected types and values for such constants in the Info.Types map.

cc: @findleyr

@griesemer griesemer added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 9, 2022
@griesemer griesemer added this to the Go1.19 milestone Feb 9, 2022
@griesemer griesemer self-assigned this Feb 9, 2022
@griesemer griesemer modified the milestones: Go1.19, Go1.20 Jul 1, 2022
@griesemer
Copy link
Contributor Author

Haven't gotten to this. Moving to 1.20.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/443756 mentions this issue: go/types, types2: add test verifying types/values of type parameter "constants"

romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Nov 3, 2022
…constants"

Fixes golang#51093.

Change-Id: Ida4025a125243159a2107dcc064a0d9addf0a675
Reviewed-on: https://go-review.googlesource.com/c/go/+/443756
Run-TryBot: Robert Griesemer <gri@google.com>
Auto-Submit: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
@golang golang locked and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

2 participants