Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: propagatedirectoryFilter to underlying go command go/packages #51265

Open
hyangah opened this issue Feb 18, 2022 · 0 comments
Open

x/tools/gopls: propagatedirectoryFilter to underlying go command go/packages #51265

hyangah opened this issue Feb 18, 2022 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/later

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 18, 2022

As discussed in #42965 (comment) gopls can utilize go's overlay feature to make go commands ignore directories. Reflect the directoryFilter setting when building overlay.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 18, 2022
@gopherbot gopherbot added this to the Unreleased milestone Feb 18, 2022
@hyangah hyangah modified the milestones: Unreleased, gopls/on-deck Feb 18, 2022
@gonzojive gonzojive mentioned this issue Apr 19, 2022
Open
@findleyr findleyr modified the milestones: gopls/later, gopls/v0.9.0 May 18, 2022
@findleyr findleyr modified the milestones: gopls/v0.9.0, gopls/later Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/later
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @findleyr