Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/crypto/ssh: data race on c.remoteId #5137

Closed
dvyukov opened this issue Mar 27, 2013 · 8 comments
Closed

x/crypto/ssh: data race on c.remoteId #5137

dvyukov opened this issue Mar 27, 2013 · 8 comments
Milestone

Comments

@dvyukov
Copy link
Member

@dvyukov dvyukov commented Mar 27, 2013

$ go test -race code.google.com/p/go.crypto/ssh

WARNING: DATA RACE
Write by goroutine 20:
  code.google.com/p/go.crypto/ssh.(*clientChan).waitForChannelOpenResponse()
      code.google.com/p/go.crypto/ssh/channel.go:482 +0x250
  code.google.com/p/go.crypto/ssh.(*ClientConn).NewSession()
      code.google.com/p/go.crypto/ssh/session.go:538 +0x1f5
  code.google.com/p/go.crypto/ssh.TestInvalidServerMessage()
      code.google.com/p/go.crypto/ssh/session_test.go:287 +0xb0
  testing.tRunner()
      src/pkg/testing/testing.go:346 +0x12f
  gosched0()
      src/pkg/runtime/proc.c:1209 +0x9f

Previous read by goroutine 22:
  code.google.com/p/go.crypto/ssh.(*channel).sendClose()
      code.google.com/p/go.crypto/ssh/channel.go:105 +0x3f
  code.google.com/p/go.crypto/ssh.(*clientChan).Close()
      code.google.com/p/go.crypto/ssh/channel.go:499 +0x16d
  code.google.com/p/go.crypto/ssh.(*chanList).closeAll()
      code.google.com/p/go.crypto/ssh/client.go:510 +0xe9
  code.google.com/p/go.crypto/ssh.func·005()
      code.google.com/p/go.crypto/ssh/client.go:198 +0xab
  code.google.com/p/go.crypto/ssh.(*ClientConn).mainLoop()
      code.google.com/p/go.crypto/ssh/client.go:203 +0xfb
  gosched0()
      src/pkg/runtime/proc.c:1209 +0x9f

Goroutine 20 (running) created at:
  testing.RunTests()
      src/pkg/testing/testing.go:426 +0xaef
  testing.Main()
      src/pkg/testing/testing.go:358 +0xab
  main.main()
      code.google.com/p/go.crypto/ssh/_test/_testmain.go:125 +0xda
  runtime.main()
      src/pkg/runtime/proc.c:182 +0x91

Goroutine 22 (finished) created at:
  code.google.com/p/go.crypto/ssh.Client()
      code.google.com/p/go.crypto/ssh/client.go:47 +0x2bd
  code.google.com/p/go.crypto/ssh.Dial()
      code.google.com/p/go.crypto/ssh/client.go:431 +0xa7
  code.google.com/p/go.crypto/ssh.dial()
      code.google.com/p/go.crypto/ssh/session_test.go:75 +0x549
  code.google.com/p/go.crypto/ssh.TestInvalidServerMessage()
      code.google.com/p/go.crypto/ssh/session_test.go:285 +0x45
  testing.tRunner()
      src/pkg/testing/testing.go:346 +0x12f
  gosched0()
      src/pkg/runtime/proc.c:1209 +0x9f
@dsymonds
Copy link
Member

@dsymonds dsymonds commented Mar 28, 2013

Comment 1:

Labels changed: added priority-later, removed priority-triage.

Owner changed to @agl.

Status changed to Accepted.

@dvyukov
Copy link
Member Author

@dvyukov dvyukov commented Jul 24, 2013

Comment 2:

ping
@davecheney
Copy link
Contributor

@davecheney davecheney commented Jul 24, 2013

Comment 3:

Thanks for the nudge, i'll try to move this up my priority list.

Owner changed to @davecheney.

@hanwen
Copy link
Contributor

@hanwen hanwen commented Nov 11, 2013

Comment 4:

this has been fixed in gosshnew.
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 5:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 6:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 7:

Labels changed: added repo-crypto.

@mikioh mikioh changed the title go.crypto/ssh: data race on c.remoteId ssh: data race on c.remoteId Jan 7, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title ssh: data race on c.remoteId x/crypto/ssh: data race on c.remoteId Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-crypto label Apr 14, 2015
@hanwen
Copy link
Contributor

@hanwen hanwen commented Aug 12, 2015

@ianlancetaylor can be closed.

@hanwen hanwen closed this Aug 13, 2015
@golang golang locked and limited conversation to collaborators Aug 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.