x/build/dashboard: many builders are configured with GO_DISABLE_OUTBOUND_NETWORK=1, but it has effect only on linux-386-stretch, linux-amd64-stretch #51444
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
dmitshur
added
Builders
|
Change https://go.dev/cl/389394 mentions this issue: |
gopherbot
pushed a commit
to golang/website
that referenced
this issue
Mar 2, 2022
One test case added in CL 388016 depends on production resources, specifically the snippet https://play.golang.org/p/MAohLsrz7JQ.go served by the production instance of the Go playground. This would be caught by TryBots where internet access is disabled, but that didn't happen due to golang/go#51444. Updates golang/go#51181. Fixes golang/go#51439. Change-Id: I4f1c5ea1a6ccad9ae4e5cbb749e3dee0b26731b5 Reviewed-on: https://go-review.googlesource.com/c/website/+/389394 Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Jamal Carvalho <jamalcarvalho@google.com> Trust: Dmitri Shuralyov <dmitshur@google.com>
|
Let's consider putting these in the trybot set for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Issue #51439 demonstrates that
linux-386-stretch,linux-amd64-stretchbuilders correctly failed when internet access (to something other than https://proxy.golang.org and https://vcs-test.golang.org) was accidentally needed for a test to run, but many other Linux builders did not, despite their configuration including "GO_DISABLE_OUTBOUND_NETWORK=1".The buildlet binary is currently responsible for implementing the internet shut-off, perhaps something broke? Maybe by now we have a better way available to implement this?
CC @golang/release.
The text was updated successfully, but these errors were encountered: