You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
cmd/compile: embedding comparable is not considered in calculating type sets #51472
changed the title [-]cmd/compile: it looks embedding comprable is not considered in calculating tyep sets[/-][+]cmd/compile: it looks embedding comparable is not considered in calculating type sets[/+]on Mar 4, 2022
changed the title [-]cmd/compile: it looks embedding comparable is not considered in calculating type sets[/-][+]cmd/compile: embedding comparable is not considered in calculating type sets[/+]on Mar 4, 2022
Briefly looked at this. It appears we're forgetting to consider the "comparable" field in typesets under some circumstances. Appears like a trivial oversight, as the actual type set computations are ok. Will fix tomorrow.
Quick update: fix is pending but given that we're so short before the release, I'll spend some time adding more tests; this shouldn't have slipped. CL probably later today or tomorrow.
Activity
ianlancetaylor commentedon Mar 4, 2022
CC @griesemer @findleyr
[-]cmd/compile: it looks embedding comprable is not considered in calculating tyep sets[/-][+]cmd/compile: it looks embedding comparable is not considered in calculating type sets[/+][-]cmd/compile: it looks embedding comparable is not considered in calculating type sets[/-][+]cmd/compile: embedding comparable is not considered in calculating type sets[/+]griesemer commentedon Mar 4, 2022
Briefly looked at this. It appears we're forgetting to consider the "comparable" field in typesets under some circumstances. Appears like a trivial oversight, as the actual type set computations are ok. Will fix tomorrow.
griesemer commentedon Mar 4, 2022
Quick update: fix is pending but given that we're so short before the release, I'll spend some time adding more tests; this shouldn't have slipped. CL probably later today or tomorrow.
gopherbot commentedon Mar 4, 2022
Change https://go.dev/cl/390025 mentions this issue:
types2: correctly include comparable in type set intersectiongopherbot commentedon Mar 7, 2022
Change https://go.dev/cl/390419 mentions this issue:
[release-branch.go1.18] go/types, types2: correctly include comparable in type set intersection[release-branch.go1.18] go/types, types2: correctly include comparabl…
go/types, types2: correctly include comparable in type set intersection