Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/dist: when using GOROOT_FINAL, require GOROOT to be explicitly provided #51504

Open
dmitshur opened this issue Mar 5, 2022 · 0 comments
Open
Labels
NeedsInvestigation
Milestone

Comments

@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented Mar 5, 2022

Based on my current understanding, I think we should make it a fatal error if the GOROOT_FINAL environment variable is set to a non-empty string, but the GOROOT environment variable is unset or set to an empty string. Doing this should reduce the costs of maintaining and developing Go, without negatively affecting utility.

That is, if GOROOT_FINAL needs to be set (rare), it isn't unreasonable to require GOROOT to also be set explicitly in order to avoid possible ambiguity that arises if it isn't set.

This is a follow up from #50893 (comment).

Issue #42563 might be relevant here, in that this requires knowing the explicit environment the user provided while calling make.bash, and not get confused if make.bash itself sets GOROOT.

@dmitshur dmitshur added the NeedsInvestigation label Mar 5, 2022
@dmitshur dmitshur added this to the Backlog milestone Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

1 participant