Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: javascript links to wrong lines (cs.opensource.google) #51624

Open
mindfarm opened this issue Mar 11, 2022 · 2 comments
Open

x/pkgsite: javascript links to wrong lines (cs.opensource.google) #51624

mindfarm opened this issue Mar 11, 2022 · 2 comments

Comments

@mindfarm
Copy link

@mindfarm mindfarm commented Mar 11, 2022

What version of Go are you using (go version)?

$ go version

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

Chrome/Ubuntu

go env Output
$ go env

What did you do?

When I go to
https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1792 I click on "QueryRowContext"

What did you expect to see?

I expect to be taken to the defintion of that method

What did you see instead?

I am taken instead to
https://cs.opensource.google/go/go/+/refs/tags/go1.17.8:src/database/sql/sql.go;l=1814
Which is an unrelated call inside an unrelated method

It was pointed out that the definition for db.QueryRowContext on master is at https://cs.opensource.google/go/go/+/master:src/database/sql/sql.go;l=1814

It appears that the problem is that the javascript is confusing the branches that it is on, it is linking to

@gopherbot gopherbot added this to the pkgsite/unplanned milestone Mar 11, 2022
@jamalc
Copy link

@jamalc jamalc commented Mar 14, 2022

I've submitted this feedback to cs.opensource.google. We can leave this open for visibility, but this is out of scope for pkgsite.

@mindfarm
Copy link
Author

@mindfarm mindfarm commented Mar 14, 2022

Thanks, I wasn't sure where to raise it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants