Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/gob: performance regression on tip vs 1.0.3 on amd64 #5165

Closed
davecheney opened this issue Mar 31, 2013 · 5 comments
Closed

encoding/gob: performance regression on tip vs 1.0.3 on amd64 #5165

davecheney opened this issue Mar 31, 2013 · 5 comments

Comments

@davecheney
Copy link
Contributor

@davecheney davecheney commented Mar 31, 2013

What steps will reproduce the problem?
1. git clone https://github.com/davecheney/autobench
2. cd autobench
3. make bench

# autobench is a small harness for running the Go 1.1 go1 tests against go 1.0.3 and tip.

What is the expected output? What do you see instead?

On linux/amd64 several people have reported GobEncode wall time has increased
significantly 

BenchmarkGobEncode                 11127380     14413551  +29.53%

Please use labels and text to provide additional information.
@davecheney
Copy link
Contributor Author

@davecheney davecheney commented Mar 31, 2013

Comment 1:

No performance regression is visible in the same proportion on 386 or arm (see sample
results in the autobench repository)
@robpike
Copy link
Contributor

@robpike robpike commented May 18, 2013

Comment 2:

Labels changed: added go1.2maybe, removed go1.1maybe.

@davecheney
Copy link
Contributor Author

@davecheney davecheney commented Jun 1, 2013

Comment 3:

Labels changed: added priority-later, performance, removed priority-triage.

@rsc
Copy link
Contributor

@rsc rsc commented Jul 30, 2013

Comment 4:

Labels changed: added feature.

@robpike
Copy link
Contributor

@robpike robpike commented Aug 16, 2013

Comment 5:

Probably a stack split. Gob in particular seems prone to them. Hoping the issue will go
away with the new stack regime; marking this WontFix.

Status changed to WontFix.

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.