Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: irgen uses wrong dict param to generate code for getting dict type [1.18 backport] #51669

Closed
gopherbot opened this issue Mar 14, 2022 · 4 comments
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 14, 2022

@dmitshur requested issue #51413 to be considered for backport to the next 1.18 minor release.

@gopherbot Please consider this for backport to 1.18. This is a serious issue—see #51460 (comment) and #51460 (comment) for detailed rationale to backport.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 15, 2022

Change https://go.dev/cl/392614 mentions this issue: [release-branch.go1.18] cmd/compile: fix wrong dict param when getting dict type

@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 15, 2022
@bcmills
Copy link
Member

@bcmills bcmills commented Mar 15, 2022

Can this be retitled to refer to the nature of the defect rather than the first symptom we happened to notice?

@cuonglm cuonglm changed the title cmd/compile: test/typeparam/mdempsky/13.go failing on noopt builder [1.18 backport] cmd/compile: irgen uses wrong dict param to generate code for getting dict type [1.18 backport] Mar 16, 2022
@toothrot toothrot added the CherryPickApproved label Mar 23, 2022
@toothrot
Copy link
Contributor

@toothrot toothrot commented Mar 23, 2022

Approved. This is a serious issue with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate label Mar 23, 2022
gopherbot pushed a commit that referenced this issue Apr 4, 2022
…g dict type

CL 338129 added getDictionaryType to get the dictionary type from the
specified dict param, but still using the one in info.dictParam, which
is wrong.

Fixes #51669

Change-Id: Ie13460c1e5751c4c5fc44479a44f6eed8b3b06e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/391994
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/392614
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 4, 2022

Closed by merging 39a8c8c to release-branch.go1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

3 participants