x/website: fails to deploy with Go 1.18

[heschi]

golang.org is failing to deploy due to failing tests:

Step #6: testdata/web.txt:272: code = "500", want "200"
Step #6: 
Step #6: ## GET https://go.dev/pkg/net/http/?m=old
Step #6: testdata/web.txt:277: GET https://go.dev/pkg/net/http/?m=old
Step #6: testdata/web.txt:278: body does not contain `title="Added in Go 1.11"` (but should)

https://tip.golang.org/pkg/net/http/?m=old shows:

to, err := human()
//go:build comment without // +build comment

For now we're going to keep the website on 1.17.

cc @rsc @golang/release

[dmitshur]

This is related to golang.org/x/website/cmd/golangorg being currently deployed to App Engine with go116 runtime:

https://github.com/golang/website/blob/18753261dd3ced20943afdc947097527359d3f63/cmd/golangorg/app.yaml#L5

I'll send a CL to x/website to add the latest spec documents as a temporary workaround while this issue is worked on.

[gopherbot]

Change https://go.dev/cl/393115 mentions this issue: _content/doc: temporarily add Go language specification documents

[rsc]

Well that's embarrassing. I will vendor in a copy of go/build I guess.

[rsc]

So was tip just broken for a long time and we didn't notice?

[dmitshur]

@rsc I expect so, at least since those old-style // +build comments were removed on tip, thought can't back that up without looking closer.

I'm not sure if there's more work involved in updating x/website's documentation rendering to handle generics. I left #48264 (comment) but that issue was about x/pkgsite.

[dmitshur]

#44356 (comment) suggests the https://tip.golang.org/pkg/net/http/?m=old problem existed since Oct 28, 2021.

[rsc]

Oh, and the tip redirect meant that most people didn't notice.

[gopherbot]

Change https://go.dev/cl/393194 mentions this issue: all: handle Go 1.18 code on Go 1.16 AppEngine using new internal/backport/go/*