Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: some tests fails on Windows with CGO_ENABLED=0 [1.18 backport] #51697

Closed
gopherbot opened this issue Mar 16, 2022 · 3 comments
Closed
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link
Contributor

@ianlancetaylor requested issue #51695 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport issues

These tests will fail if run with CGO_ENABLED=0. The fix is trivial and test-only. We may as well backport it.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 16, 2022
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 16, 2022
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/393699 mentions this issue: [release-branch.go1.18] runtime: call testenv.MustHaveCGO in a couple of tests

@toothrot toothrot added the CherryPickApproved Used during the release process for point releases label Mar 23, 2022
@toothrot
Copy link
Contributor

Approved.

@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 23, 2022
@gopherbot
Copy link
Contributor Author

Closed by merging 677c6fe to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Mar 28, 2022
… of tests

For #51695
Fixes #51697

Change-Id: Icfe9d26ecc28a7db9040d50d4661cf9e8245471e
Reviewed-on: https://go-review.googlesource.com/c/go/+/392916
Trust: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 2d32594)
Reviewed-on: https://go-review.googlesource.com/c/go/+/393699
Reviewed-by: Emmanuel Odeke <emmanuel@orijtech.com>
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 12, 2022
@golang golang locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants