Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: wrong type assertion result when using generic types [1.18 backport] #51738

Closed
gopherbot opened this issue Mar 17, 2022 · 2 comments
Closed
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 17, 2022

@ianlancetaylor requested issue #51700 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18.

This appears to be incorrect code generation, so we should backport the fix when we have one.

@gopherbot gopherbot added the CherryPickCandidate label Mar 17, 2022
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 17, 2022
@cherrymui cherrymui changed the title go/runtime: wrong type assertion result when using generic types [1.18 backport] runtime: wrong type assertion result when using generic types [1.18 backport] Apr 1, 2022
@dmitshur dmitshur removed this from the Go1.18.1 milestone Apr 12, 2022
@dmitshur dmitshur added this to the Go1.18.2 milestone Apr 12, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 12, 2022

Change https://go.dev/cl/399974 mentions this issue: [release-branch.go1.18] cmd/compile: always write fun[0] in incomplete itab

@heschi heschi added the CherryPickApproved label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Apr 20, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 9, 2022

Closed by merging 2375a68 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
…e itab

runtime.getitab need filled fun[0] to identify whether
implemented the interface.

Fixes #51738
Fixes #52244

Change-Id: I0173b98f4e1b45e3a0183a5b60229d289140d1e6
Reviewed-on: https://go-review.googlesource.com/c/go/+/399058
Reviewed-by: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/399974
Reviewed-by: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

3 participants