Skip to content

x/website: Dead links for sub-repositories #51785

@sakjur

Description

@sakjur

What did you do?

Got 404 when following links from go1compat to golang.org/x/sys.

What did you expect to see?

End result: if I click on the link in a browser, I'd expected to be redirected to https://pkg.go.dev/golang.org/x/net

Presumably, this would be either by means of the URL being an absolute https://golang.org/x/net as it was before or go.dev resolving https://go.dev/x/net the same as golang.org.

What did you see instead?

golang/website@ab4f479 changed all links to go.dev or golang.org to relative links, including links to sub-repositories under golang.org/x, so that they now link to https://go.dev/x/net (not found) instead of https://golang.org/x/net (redirecting to the docs of the package).

The problem seems to be present in the following places:

./_content/doc/go1.4.html:130:using the supporting packages in the <a href="/x/mobile">mobile</a> subrepository.
./_content/doc/go1.4.html:615:A new subrepository, <a href="/x/sys">golang.org/x/sys</a>,
./_content/doc/go1.7.html:40:<a href="/x/net/context">x/net subrepository</a>
./_content/doc/go1compat.html:167:<a href="/x/net">golang.org/x/net</a>,
./_content/doc/go1compat.html:184:<a href="/x/sys">go.sys</a> subrepository.
./_content/doc/go1.6.html:281:<a href="/x/net/http2"><code>golang.org/x/net/http2</code></a>,

I know this could've been a very small CL submission instead, however, I think I'd have to ask my employer to sign the CLA for me to do so, and that seems like a chore I'd rather do without this time. 🙈

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions