Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: internal compiler error: walkExpr: switch 1 unknown op RECOVER [1.18 backport] #51846

Closed
gopherbot opened this issue Mar 21, 2022 · 3 comments
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 21, 2022

@ianlancetaylor requested issue #51839 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18

This is an internal compiler error on valid code.

@gopherbot gopherbot added the CherryPickCandidate label Mar 21, 2022
@gopherbot gopherbot added this to the Go1.18.1 milestone Mar 21, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Mar 21, 2022

Change https://go.dev/cl/394080 mentions this issue: [release-branch.go1.18] cmd/compile: fix panic with nested dead hidden closures

@toothrot toothrot added the CherryPickApproved label Mar 23, 2022
@toothrot
Copy link
Contributor

@toothrot toothrot commented Mar 23, 2022

Approved. This is a serious issue with no workaround.

@gopherbot gopherbot removed the CherryPickCandidate label Mar 23, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 4, 2022

Closed by merging c258e9d to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue Apr 4, 2022
…n closures

CL 342350 fixed deadcode panic with dead hidden closures. However, a
closure may contains nested dead hidden closures, so we need to mark
them dead as well.

Fixes #51846

Change-Id: Ib54581adfc1bdea60e74d733cd30fd8e783da983
Reviewed-on: https://go-review.googlesource.com/c/go/+/394079
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/394080
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

2 participants