Skip to content

proposal: testing: Support external packages to call testing.MainStart #51912

Closed

Description

@emcfarlane

Systems simulating go test have two methods to invoke tests:

From the doc comments for Main, MainStart is preferred:

Systems simulating "go test" should be updated to use MainStart.

Previously, before go1.18, the internal interface testDeps could be satisfied by an external package. Upgrading to go1.18 the new internal interface contains methods with references to a private struct corpusEntry for the added fuzzing support. MainStart isn't part of the go compatibility promise. I propose providing an implementation of testDeps like

type matchStringOnly func(pat, str string) (bool, error)

that could be used by external packages to call MainStart.

Activity

  1. changed the title [-]testing: Support external packages to call testing.MainStart[/-] [+]proposal: testing: Support external packages to call testing.MainStart[/+] on Mar 24, 2022
  2. added this to the Proposal milestone on Mar 24, 2022
  3. seankhliao commented on Mar 24, 2022

    @seankhliao
    Member
  4. emcfarlane commented on Mar 25, 2022

    @emcfarlane
    Author

    My mistake, struct isn't private but an alias:

    type CorpusEntry = struct {

    Would be nice to have a defined public testdeps implementation but not a blocker, happy to close.

  5. ianlancetaylor commented on Mar 30, 2022

    @ianlancetaylor
    Contributor

    Doesn't seem like there is anything we need to do here, so closing. Please comment if you disagree.

  6. locked and limited conversation to collaborators on Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions