Skip to content

x/website: support patchset syntax for CL redirects #52023

@rolandshoemaker

Description

@rolandshoemaker

Currently the go.dev/cl/... redirect doesn't support patchset syntax, i.e. go.dev/cl/c/1234/5. This breaks some tooling, like Linkable, which generate shortened URLs using the typical Gerrit syntax (the assumption being that go.dev/cl/c/1234/5 will redirect to go-review.googlesource.com/c/1234/5) if you are trying to link to a specific patchset.

Dmitri suggested in http://go.dev/cl/396494 that we support linking to patchsets, but without the extra /c/ prefix that Gerrit uses (i.e. we'd redirect from go.dev/cl/1234/5 to go-review.googlesource.com/c/1234/5) which seems reasonable. This would require fixing how tooling like Linkable generate their shortened links, but that seems fine.

cc @dmitshur

Metadata

Metadata

Assignees

No one assigned

    Labels

    FrozenDueToAgeNeedsFixThe path to resolution is known, but the work has not been done.

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions