Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/test: timeouts in TestIntendedInlining #52081

Closed
bcmills opened this issue Mar 31, 2022 · 5 comments
Closed

cmd/compile/internal/test: timeouts in TestIntendedInlining #52081

bcmills opened this issue Mar 31, 2022 · 5 comments
Labels
NeedsInvestigation release-blocker
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Mar 31, 2022

goroutine 321 [syscall, 2 minutes]:
runtime.syscall_wait4(0x1c96, 0xc0004c8010, 0x0, 0xc001148090)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/syscall_solaris.go:294 +0x86 fp=0xc000738e60 sp=0xc000738e08 pc=0x464ee6
syscall.Wait4(0x49634d?, 0x7fffbf523d68?, 0x0?, 0xc00038cd00?)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/syscall/syscall_solaris.go:250 +0x2c fp=0xc000738ea8 sp=0xc000738e60 pc=0x47468c
os.(*Process).wait(0xc0000aa060)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec_unix.go:43 +0x85 fp=0xc000738f00 sp=0xc000738ea8 pc=0x49efa5
os.(*Process).Wait(...)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc0010b8c60)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:507 +0x54 fp=0xc000738f78 sp=0xc000738f00 pc=0x533c74
os/exec.(*Cmd).Run(0xc00075c820?)
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:341 +0x39 fp=0xc000738f98 sp=0xc000738f78 pc=0x532dd9
cmd/compile/internal/test.TestIntendedInlining.func1()
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/cmd/compile/internal/test/inl_test.go:228 +0x2f fp=0xc000738fe0 sp=0xc000738f98 pc=0x779aef
runtime.goexit()
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/runtime/asm_amd64.s:1571 +0x1 fp=0xc000738fe8 sp=0xc000738fe0 pc=0x468261
created by cmd/compile/internal/test.TestIntendedInlining
	/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/cmd/compile/internal/test/inl_test.go:227 +0x1445

greplogs --dashboard -md -l -e 'panic: test timed out(?:.*\n)*^goroutine \d+ \[syscall, \d+ minutes\]:\n(.+\n\t.+\n)*cmd/compile/internal/test\.TestIntendedInlining'

2022-03-31T12:55:38-821420d/solaris-amd64-oraclerel
2021-04-29T16:31:18-5a8435d/freebsd-amd64-race
2021-04-23T21:43:06-e5a6c52/freebsd-386-11_4

(CC @mvdan)

@bcmills bcmills added this to the Backlog milestone Mar 31, 2022
@bcmills bcmills added the NeedsInvestigation label Mar 31, 2022
@bcmills
Copy link
Member Author

@bcmills bcmills commented Mar 31, 2022

This test is normally skipped in short mode, but for some reason not on the Go builders:
https://cs.opensource.google/go/go/+/master:src/cmd/compile/internal/test/inl_test.go;l=23-25;drc=4a37a1d49fd472665b59b581fe6563a9e578fd71

Maybe we should just drop the builder-specific part of that condition? 🤔

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 25, 2022

greplogs --dashboard -md -l -e 'panic: test timed out(?:.*\n)*^goroutine \d+ \[syscall, \d+ minutes\]:\n(.+\n\t.+\n)*cmd/compile/internal/test\.TestIntendedInlining' --since=2022-03-31

2022-03-31T12:55:38-821420d/solaris-amd64-oraclerel

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 25, 2022

Marking as release-blocker for Go 1.19 since this is causing test failures on multiple platforms.

Since none of the failing platforms so far is a first-class port, the cmd/compile maintainers (@randall77, @griesemer) could choose to update the skips for this test and move it to the backlog.

(My suggestion above is to drop the testenv.Builder() == "" part of the condition and only run the test on the -longtest builders, but other configurations — such as also running the test on a selection of first-class ports with TryBots — would also resolve this for now.)

@bcmills bcmills removed this from the Backlog milestone Apr 25, 2022
@bcmills bcmills added this to the Go1.19 milestone Apr 25, 2022
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 18, 2022

@golang/runtime Pinging because this is a release blocker because it's causing builder failures, but I agree with Bryan that we probably just need to not let this test run on non-longtest builders.

@gopherbot
Copy link

@gopherbot gopherbot commented May 18, 2022

Change https://go.dev/cl/407015 mentions this issue: cmd/compile/internal/test: make TestIntendedInlining faster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants