Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: fails to compile very long files starting go1.17 [1.17 backport] #52095

Closed
gopherbot opened this issue Apr 1, 2022 · 3 comments
Closed

cmd/compile: fails to compile very long files starting go1.17 [1.17 backport] #52095

gopherbot opened this issue Apr 1, 2022 · 3 comments
Labels
CherryPickApproved
Milestone
Go1.17.10

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 1, 2022

@shawn-xdji requested issue #51193 to be considered for backport to the next 1.17 minor release.

My apologies for commenting a closed issue, we ran into the error in practice when compiling a large auto-generated file, feasible to make a backport? Thanks.

@gopherbot please consider this for backport to 1.17, it's a compiler error.
@gopherbot gopherbot added the CherryPickCandidate label Apr 1, 2022
@gopherbot gopherbot mentioned this issue Apr 1, 2022
Closed
@gopherbot gopherbot added this to the Go1.17.9 milestone Apr 1, 2022
@dmitshur dmitshur removed this from the Go1.17.9 milestone Apr 12, 2022
@dmitshur dmitshur added this to the Go1.17.10 milestone Apr 12, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 20, 2022

Change https://go.dev/cl/401315 mentions this issue: cmd/compile: drop column info when line number saturates

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 20, 2022

Change https://go.dev/cl/401315 mentions this issue: [release-branch.go1.17] cmd/compile: drop column info when line number saturates

@dr2chase dr2chase added the CherryPickApproved label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate label May 4, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 9, 2022

Closed by merging feec92c to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue May 9, 2022
@randall77 @heschi
[release-branch.go1.17] cmd/compile: drop column info when line numbe…
feec92c 
…r saturates

When line number saturates, we can end up getting non-monotonic
position info, because the start of the next line after line=lineMax,col=2
is line=lineMax,col=1.

Instead, if line==lineMax, make the column always 0 (no column info).
If the line number is wrong, having column info probably isn't that helpful.

Fixes #52095

Change-Id: If3d90472691b1f6163654f3505e2cb98467f2383
Reviewed-on: https://go-review.googlesource.com/c/go/+/385795
Trust: Keith Randall <khr@golang.org>
Reviewed-by: Than McIntosh <thanm@google.com>
(cherry picked from commit 1de2344)
Reviewed-on: https://go-review.googlesource.com/c/go/+/401315
Reviewed-by: Keith Randall <khr@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.17.10
Development

No branches or pull requests
3 participants
@dmitshur @dr2chase @gopherbot