Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: TestGroupCleanupUserNamespace failure on linux-s390x-ibm [1.17 backport] #52148

Closed
gopherbot opened this issue Apr 4, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #52088 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.17 and 1.18. This is a test-only fix for an issue exposed by a builder upgrade.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 4, 2022
@gopherbot gopherbot added this to the Go1.17.9 milestone Apr 4, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/398235 mentions this issue: [release-branch.go1.17] syscall: relax output check in TestGroupCleanupUserNamespace

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 4, 2022
@dmitshur dmitshur modified the milestones: Go1.17.9, Go1.17.10 Apr 12, 2022
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

Closed by merging 2150be1 to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue May 4, 2022
…upUserNamespace

“If you have a procedure with ten parameters, you probably missed some.”
― attr. Alan J. Perlis

I argue that the same is true for hard-coded special cases.

In TestGroupCleanupUserNamespace, instead of a curated list of strings
observed in the wild we now check for a prefix, as was done for
TestGroupCleanup in CL 24670.

Updates #52088.
Fixes #52148.

Change-Id: I59c5b0c048113e306996c0f8247e09c714d2423a
Reviewed-on: https://go-review.googlesource.com/c/go/+/397316
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 434b2a5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/398235
Reviewed-by: Ian Lance Taylor <iant@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants