Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syscall: TestGroupCleanupUserNamespace failure on linux-s390x-ibm [1.18 backport] #52149

Closed
gopherbot opened this issue Apr 4, 2022 · 4 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link

@bcmills requested issue #52088 to be considered for backport to the next 1.18 minor release.

@gopherbot, please backport to Go 1.17 and 1.18. This is a test-only fix for an issue exposed by a builder upgrade.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 4, 2022
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 4, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/398234 mentions this issue: [release-branch.go1.18] syscall: relax output check in TestGroupCleanupUserNamespace

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Apr 4, 2022
@dmitshur
Copy link
Contributor

@jonathan-albrecht-ibm Based on #52088 (comment) I expected to see the linux-s390x-ibm builder currently failing at https://build.golang.org/?branch=release-branch.go1.18, which this backport would fix, but it seems to be passing. Is it because the failure is non-deterministic or is there another reason? Asking to understand this better, though I expect this is fine to backport. Thanks.

@jonathan-albrecht-ibm
Copy link
Contributor

@dmitshur I'm in the process of provisioning two new builders and the issue came up when testing them. I stopped the new builders as soon as I saw the failure so that's why its not currently happening.

The current builders are not triggering this issue probably because they are on an older RHEL version (8.2) and the new builders are on the latest RHEL 8.5 version. I haven't been able to track down the exactly what selinux configuration causes the difference but I don't think there is any misconfiguration of the new builders. I think I was just unlucky enough to hit another valid selinux configuration that wasn't yet covered by the expected values in the test.

The failure is definitely deterministic and to the best of my understanding not platform dependent in any way.

@dmitshur dmitshur modified the milestones: Go1.18.1, Go1.18.2 Apr 12, 2022
@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

Closed by merging a286c7d to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 4, 2022
…upUserNamespace

“If you have a procedure with ten parameters, you probably missed some.”
― attr. Alan J. Perlis

I argue that the same is true for hard-coded special cases.

In TestGroupCleanupUserNamespace, instead of a curated list of strings
observed in the wild we now check for a prefix, as was done for
TestGroupCleanup in CL 24670.

Updates #52088.
Fixes #52149.

Change-Id: I59c5b0c048113e306996c0f8247e09c714d2423a
Reviewed-on: https://go-review.googlesource.com/c/go/+/397316
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
(cherry picked from commit 434b2a5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/398234
Reviewed-by: Russ Cox <rsc@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

4 participants