Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: TestDialParallel failures due to longer-than-expected delay on Windows #52173

Closed
bcmills opened this issue Apr 5, 2022 · 3 comments
Closed
Assignees
Labels
NeedsInvestigation release-blocker
Milestone

Comments

@bcmills
Copy link
Member

@bcmills bcmills commented Apr 5, 2022

--- FAIL: TestDialParallel (6.16s)
    dial_test.go:173: dialClosedPort: measured delay 1.0028044s
    dial_test.go:313: #5: got 1.2757236s; want <= 1.20336528s
FAIL
FAIL	net	55.514s

greplogs --dashboard -md -l -e 'FAIL: TestDialParallel .*(?:\n .*)*got .*; want <= .*'

2022-04-05T18:01:26-9e16cc1/windows-amd64-longtest

Note that the test currently uses a hard-coded heuristic for the timing bounds:
https://cs.opensource.google/go/go/+/master:src/net/dial_test.go;l=302-309;drc=da7891f6f36c48f2931ed916ed305330c06f9bd7

(See previously #35616; CC @ianlancetaylor @neild.)

@bcmills
Copy link
Member Author

@bcmills bcmills commented Apr 5, 2022

Since windows/amd64 is a first-class port, this is a release-blocker for Go 1.19.

(It may be possible to resolve by making the timing bounds even more lax, or by somehow eliminating the timing bounds entirely if the test is meaningful without them.)

@bcmills bcmills added NeedsInvestigation release-blocker labels Apr 5, 2022
@bcmills bcmills added this to the Go1.19 milestone Apr 5, 2022
@bcmills bcmills changed the title net: TestDialParallel failures due to net: TestDialParallel failures due to longer-than-expected delay on Windows Apr 6, 2022
@prattmic
Copy link
Member

@prattmic prattmic commented May 20, 2022

FWIW, I've been attempting to reproduce a different Windows issue, but have managed to reproduce this twice thus far in ~1hr of testing with 25 windows-amd64-longtest gomotes running all.bat using https://github.com/mknyszek/goswarm/.

Edit: I got 58(!) cases of this over the weekend.

@gopherbot
Copy link

@gopherbot gopherbot commented May 24, 2022

Change https://go.dev/cl/408354 mentions this issue: net: add even more timing slop for TestDialParallel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation release-blocker
Projects
Status: Done
Development

No branches or pull requests

4 participants