Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: compiler crash on valid code [1.18 backport] #52242

Closed
gopherbot opened this issue Apr 8, 2022 · 3 comments
Closed

cmd/compile: compiler crash on valid code [1.18 backport] #52242

gopherbot opened this issue Apr 8, 2022 · 3 comments
Labels
CherryPickApproved
Milestone
Go1.18.3

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 8, 2022

@ianlancetaylor requested issue #52241 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport to 1.18

This is a compiler crash on valid code.
@gopherbot gopherbot added the CherryPickCandidate label Apr 8, 2022
@gopherbot gopherbot mentioned this issue Apr 8, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 8, 2022
@dmitshur dmitshur removed this from the Go1.18.1 milestone Apr 12, 2022
@dmitshur dmitshur added this to the Go1.18.2 milestone Apr 12, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 7, 2022

Change https://go.dev/cl/404774 mentions this issue: [release-branch.go1.18] cmd/compile: allow exporting .rcvr ident

@heschi heschi removed this from the Go1.18.2 milestone May 10, 2022
@heschi heschi added this to the Go1.18.3 milestone May 10, 2022
@toothrot toothrot added the CherryPickApproved label May 25, 2022
@gopherbot gopherbot removed the CherryPickCandidate label May 25, 2022
@toothrot
Copy link
Contributor

@toothrot toothrot commented May 25, 2022

Approved. Crash on valid code is a serious issue with no workaround.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 25, 2022

Closed by merging e46ac38 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 25, 2022
@wdvxdr1123 @toothrot
[release-branch.go1.18] cmd/compile: allow exporting .rcvr ident
e46ac38 
Noder pass will build a closure to implement generic function
instantiation which may produce `.dict` and `.rcvr` ident.
Since we allow `.dict` during exporting, we should allow `.rcvr` too.

Fixes #52242.

Change-Id: Ifc3912ba5155b5ac1887f20830da64f4fb3fceb6
Reviewed-on: https://go-review.googlesource.com/c/go/+/404314
Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
(cherry picked from commit ac39dbd)
Reviewed-on: https://go-review.googlesource.com/c/go/+/404774
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.18.3
Development

No branches or pull requests
4 participants
@toothrot @dmitshur @gopherbot @heschi