Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: doAllThreadsSyscall has an unaligned atomic load on 32-bit architectures [1.18 backport] #52305

Closed
gopherbot opened this issue Apr 12, 2022 · 4 comments
Closed

runtime: doAllThreadsSyscall has an unaligned atomic load on 32-bit architectures [1.18 backport] #52305

gopherbot opened this issue Apr 12, 2022 · 4 comments
Labels
CherryPickApproved
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 12, 2022

@prattmic requested issue #51776 to be considered for backport to the next 1.18 minor release.

Fixed in https://go.dev/cl/399754.

@gopherbot Please backport to 1.18. This is a regression with no workaround.
@gopherbot gopherbot added the CherryPickCandidate label Apr 12, 2022
@gopherbot gopherbot mentioned this issue Apr 12, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.1 milestone Apr 12, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 12, 2022

Change https://go.dev/cl/399954 mentions this issue: runtime: align m.procid to 8 bytes on 32-bit systems

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 12, 2022

Change https://go.dev/cl/399954 mentions this issue: [release-branch.go1.18] runtime: align m.procid to 8 bytes on 32-bit systems

@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 12, 2022

Change https://go.dev/cl/399955 mentions this issue: [release-branch.go1.18] runtime: align m.procid to 8 bytes on 32-bit systems

@dmitshur dmitshur removed this from the Go1.18.1 milestone Apr 12, 2022
@dmitshur dmitshur added this to the Go1.18.2 milestone Apr 12, 2022
@heschi heschi added the CherryPickApproved label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Apr 20, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 9, 2022

Closed by merging 4f45424 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@prattmic @heschi
[release-branch.go1.18] runtime: align m.procid to 8 bytes on 32-bit …
4f45424 
…systems

https://go-review.googlesource.com/c/go/+/383434 started using
atomic Load64 on this field, which breaks 32 bit platforms which
require 64-bit alignment of uint64s that are passed to atomic operations.

Not sure why this doesn't break everywhere, but I saw it break on
my laptop during all.bash.

For #51776.
Fixes #52305.

Change-Id: Ida27b23068b3cc7208fce3c97b69a464ccf68209
Reviewed-on: https://go-review.googlesource.com/c/go/+/399754
Run-TryBot: Keith Randall <khr@golang.org>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
(cherry-picked from commit ea7e3e3)
Reviewed-on: https://go-review.googlesource.com/c/go/+/399954
Run-TryBot: Michael Pratt <mpratt@google.com>
@bradfitz bradfitz mentioned this issue Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @heschi