Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: DetectContentType: add audio/amr signature #52334

Open
OneOfOne opened this issue Apr 13, 2022 · 5 comments
Open

net/http: DetectContentType: add audio/amr signature #52334

OneOfOne opened this issue Apr 13, 2022 · 5 comments
Labels
FeatureRequest NeedsInvestigation
Milestone

Comments

@OneOfOne
Copy link
Contributor

@OneOfOne OneOfOne commented Apr 13, 2022

The signature for that audio file type is missing.

@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Apr 13, 2022

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 13, 2022

Change https://go.dev/cl/400174 mentions this issue: net/http: DetectContentType: add audio/amr signature

@neild
Copy link
Contributor

@neild neild commented Apr 13, 2022

https://mimesniff.spec.whatwg.org/#matching-an-audio-or-video-type-pattern doesn't include a pattern for audio/amr.

@OneOfOne
Copy link
Contributor Author

@OneOfOne OneOfOne commented Apr 14, 2022

@neild I'd like to argue that it's a popular enough format in the mobile world specially with older headsets that it warrants support.

@neild
Copy link
Contributor

@neild neild commented Apr 14, 2022

We don't really want to be in the business of making judgments about what is popular enough or not. DetectContentType is documented as following the WHATWG algorithm; the way to add a new type is to convince WHATWG to add it.

@dmitshur dmitshur added NeedsInvestigation FeatureRequest labels Apr 14, 2022
@dmitshur dmitshur added this to the Backlog milestone Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

4 participants