Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile/internal/ssa: occurred the wrong rewrite cycle detection [1.18 backport] #52366

Closed
gopherbot opened this issue Apr 15, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone

Comments

@gopherbot
Copy link

gopherbot commented Apr 15, 2022

@randall77 requested issue #51639 to be considered for backport to the next 1.18 minor release.

@gopherbot please open a backport issue for 1.18.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 15, 2022
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 15, 2022
@gopherbot
Copy link
Author

gopherbot commented Apr 15, 2022

Change https://go.dev/cl/400514 mentions this issue: [release-branch.go1.18] cmd/compile: disable rewrite loop detector for deadcode-only changes

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

gopherbot commented May 9, 2022

Closed by merging 13bda0e to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
…r deadcode-only changes

We're guaranteed we won't infinite loop on deadcode-only changes,
because each change converts valid -> invalid, and there are only a
finite number of valid values.

The loops this test is looking for are those generated by rule
applications, so it isn't useful to check for loops when rules aren't
involved.

Fixes #52366

Change-Id: Idf1abeab9d47baafddc3a1197d5064faaf07ef78
Reviewed-on: https://go-review.googlesource.com/c/go/+/392760
Trust: Keith Randall <khr@golang.org>
Run-TryBot: Keith Randall <khr@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Josh Bleecher Snyder <josharian@gmail.com>
Trust: Josh Bleecher Snyder <josharian@gmail.com>
(cherry picked from commit 15728ce)
Reviewed-on: https://go-review.googlesource.com/c/go/+/400514
Reviewed-by: Cherry Mui <cherryyz@google.com>
Reviewed-by: Austin Clements <austin@google.com>
Reviewed-by: David Chase <drchase@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Development

No branches or pull requests

2 participants