Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/x509: verification with system and custom roots (backport to 1.17?) #52370

Open
dims opened this issue Apr 15, 2022 · 3 comments
Open

crypto/x509: verification with system and custom roots (backport to 1.17?) #52370

dims opened this issue Apr 15, 2022 · 3 comments
Labels
NeedsDecision

Comments

@dims
Copy link

@dims dims commented Apr 15, 2022

#16736 has been fixed in go 1.18 via https://go-review.googlesource.com/c/go/+/353589

Will the team consider back porting https://go-review.googlesource.com/c/go/+/353589 to go 1.17.x ? Is that feasible?

Context: Kubernetes/Containerd on windows has some older branches that could use this patch (example k8s 1.22.x + containerd 1.6)

Thanks,
Dims

@seankhliao seankhliao added the NeedsDecision label Apr 15, 2022
@seankhliao
Copy link
Member

@seankhliao seankhliao commented Apr 15, 2022

cc @golang/security

@jayunit100
Copy link

@jayunit100 jayunit100 commented Apr 15, 2022

On the sig-windows (kubernetes) side, for kubernetes, wed like to be able to use containerd for airgapped installations of windows kubelets - but without having this feature in containerd, we cannot .

@rosskirkpat
Copy link

@rosskirkpat rosskirkpat commented Apr 15, 2022

We hit this issue in RKE2 Windows when using self-signed certs in an airgapped environment. rancher/rke2#1648
Here’s the workaround: rancher/rke2#1648 (comment)

In short - we had to import all self-signed certs into the windows root ca store. The error was seen when containerd in rke2 Windows tried to pull images from a private registry that used a self-signed cert.
Import-Certificate -FilePath "C:\Users\Administrator\ca.pem" -CertStoreLocation cert:\CurrentUser\Root

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsDecision
Projects
None yet
Development

No branches or pull requests

4 participants