Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: executable compiled under Go 1.17.7 will occasionally wedge [1.18 backport] #52375

Closed
gopherbot opened this issue Apr 15, 2022 · 2 comments
Closed
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 15, 2022

@ianlancetaylor requested issue #52226 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport issues

This bug can cause rare cases of deadlock on macOS in programs that use syscall.Exec. The fix is simple.

@gopherbot gopherbot added the CherryPickCandidate label Apr 15, 2022
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 15, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 15, 2022

Change https://go.dev/cl/400318 mentions this issue: [release-branch.go1.18] runtime: don't block preemption signal in new M's or ensureSigM

@heschi heschi added the CherryPickApproved label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Apr 20, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 6, 2022

Closed by merging 3e79a84 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 6, 2022
… M's or ensureSigM

No test because we already have a test in the syscall package.
The issue reports 1 failure per 100,000 iterations, which is rare enough
that our builders won't catch the problem.

For #52226
Fixes #52375

Change-Id: I17633ff6cf676b6d575356186dce42cdacad0746
Reviewed-on: https://go-review.googlesource.com/c/go/+/400315
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
(cherry picked from commit e398266)
Reviewed-on: https://go-review.googlesource.com/c/go/+/400318
Reviewed-by: Austin Clements <austin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

2 participants