Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syscall: Faccessat checks wrong group [1.18 backport] #52440

Closed
gopherbot opened this issue Apr 19, 2022 · 2 comments
Closed

syscall: Faccessat checks wrong group [1.18 backport] #52440

gopherbot opened this issue Apr 19, 2022 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@neild requested issue #52313 to be considered for backport to the next 1.18 minor release.

@gopherbot please open backport issues.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Apr 19, 2022
@gopherbot gopherbot mentioned this issue Apr 19, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 19, 2022
@gopherbot
Copy link
Author

Change https://go.dev/cl/401079 mentions this issue: [release-branch.go1.18] syscall: check correct group in Faccessat

@heschi heschi added the CherryPickApproved Used during the release process for point releases label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Apr 20, 2022
@gopherbot
Copy link
Author

Closed by merging c0599c5 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@neild @heschi
[release-branch.go1.18] syscall: check correct group in Faccessat
c0599c5 
The Faccessat call checks the user, group, or other permission bits of a
file to see if the calling process can access it. The test to see if the
group permissions should be used was made with the wrong group id, using
the process's group id rather than the file's group id. Fix this to use
the correct group id.

No test since we cannot easily change file permissions when not running
as root and the test is meaningless if running as root.

For #52313
Fixes #52440

Change-Id: I4e2c84754b0af7830b40fd15dedcbc58374d75ee
Reviewed-on: https://go-review.googlesource.com/c/go/+/399539
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit f66925e)
Reviewed-on: https://go-review.googlesource.com/c/go/+/401079
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Tatiana Bradley <tatiana@golang.org>
Run-TryBot: Tatiana Bradley <tatiana@golang.org>
Auto-Submit: Tatiana Bradley <tatiana@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases release-blocker Security
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
3 participants
@neild @gopherbot @heschi