Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: incorrect handling of iota in 1.18 [1.18 backport] #52441

Closed
gopherbot opened this issue Apr 19, 2022 · 2 comments
Closed

cmd/compile: incorrect handling of iota in 1.18 [1.18 backport] #52441

gopherbot opened this issue Apr 19, 2022 · 2 comments
Labels
CherryPickApproved release-blocker
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 19, 2022

@ianlancetaylor requested issue #52438 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open a backport to 1.18.

This is an invalid compilation of a valid Go file. Earlier releases are unaffected.

@gopherbot gopherbot added the CherryPickCandidate label Apr 19, 2022
@gopherbot gopherbot added this to the Go1.18.2 milestone Apr 19, 2022
@griesemer griesemer self-assigned this Apr 19, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented Apr 19, 2022

Change https://go.dev/cl/401174 mentions this issue: [release-branch.go1.18] cmd/compile/internal/types2: use correct value of iota

@heschi heschi added the CherryPickApproved label Apr 20, 2022
@gopherbot gopherbot removed the CherryPickCandidate label Apr 20, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 2, 2022

Closed by merging 94274d0 to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 2, 2022
…e of iota

Fixes #52441.

Change-Id: I5cbf8c448dba037e9e0c5fe8f209401d6bf7d43f
Reviewed-on: https://go-review.googlesource.com/c/go/+/401134
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/401174
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Robert Griesemer <gri@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved release-blocker
Projects
None yet
Development

No branches or pull requests

4 participants