-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/website: go.dev/doc/install links to the darwin/amd64 installer for Apple Silicon users #52487
Comments
Does "Universal" already exist, or are there plans to add "Universal" to https://go.dev/dl/ ? |
@Deleplace There is currently no universal version. I expect that will involve more work from the release team's side, and I am not aware of any plan. I added this as a possibility :-) And another consideration is the potential binary size. |
To put a finer point on it: when a Apple Silicon mac user visits the download page, they are presented with this: and that big download button is the wrong link. They will probably install that package and everything will seem to work, because the emulation is very good. The programs they compile will be amd64 binaries and will run a little slower because they are running under Rosetta. They may only become aware that there is an issue when some deeper issue exposes the amd64/arm64 mismatch. (This keeps happening at our company.) I suspect that quite a large fraction of Apple Silicon Go users are using amd64 toolchains today. I really think this needs fixing. For now, we can just have two download buttons to force the user to pick the appropriate one. It also seems like the macOS installer should warn the user if they are installing the amd64 toolchain on an Apple Silicon machine. |
I filed #59010 for making the amd64 installer complain if run on Apple Silicon. |
Change https://go.dev/cl/480955 mentions this issue: |
There is no way to reliably detect system architecture and the install doc page is missing appropriate legal disclaimers and notifications. Updating the button to redirect to the download page. For #golang/go#52487. Change-Id: I032ac3ea3699a89acc916a8ffeafc018d51ff8f3 Reviewed-on: https://go-review.googlesource.com/c/website/+/480955 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Jamal Carvalho <jamal@golang.org> Auto-Submit: Jamal Carvalho <jamal@golang.org>
As the title of this issue says, when it was originally filed, the "Download" button at https://go.dev/doc/install was quite misleading. CL 480955 made it point to the https://go.dev/dl/ page that lets users see all available downloads and select one appropriate for their needs. We considered the universal installer path but decided against it (it's larger in size, creates an additional decision for users, and requires work to implement), and by this point it's less likely there will be new information that would tip the balance towards reconsindering that. It doesn't seem like there's more to do here. @hyangah Are you okay with closing this issue as resolved? |
From @dmitshur's comment in #47578 (comment) (thanks!)
I think detecting the underlying system may be difficult. Then, I think we should investigate alternatives
The text was updated successfully, but these errors were encountered: