Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/ast: ast.FilterFuncDuplicates does not distinguish between receivers and regular functions #5249

Closed
gopherbot opened this issue Apr 9, 2013 · 3 comments
Assignees

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Apr 9, 2013

by ian.wetherbee:

What steps will reproduce the problem?
1. Parse the AST of strconv/atof.go with ast.MergePackageFiles(pkg,
ast.FilterFuncDuplicates)

What is the expected output?
The resulting AST contains:
func (d *decimal) atof32() (f float32, ok bool)
func atof32(s string) (f float32, err error)

What do you see instead?
The resulting AST is missing the decimal.atof32() decl and only has:
func atof32(s string) (f float32, err error)


Which compiler are you using (5g, 6g, 8g, gccgo)?
N/A

Which operating system are you using?
Arch Linux

Which version are you using?  (run 'go version')
go version go1.0.3

Please provide any additional information below.
Bug is around this line:
https://code.google.com/p/go/source/browse/src/pkg/go/ast/filter.go#215
@ianlancetaylor
Copy link
Contributor

@ianlancetaylor ianlancetaylor commented Apr 9, 2013

Comment 1:

Owner changed to @griesemer.

@griesemer
Copy link
Contributor

@griesemer griesemer commented Apr 9, 2013

Comment 2:

Status changed to Accepted.

@griesemer
Copy link
Contributor

@griesemer griesemer commented Apr 10, 2013

Comment 3:

This issue was closed by revision d06313e.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.