Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/http: TestRequestWriteTransport failures with unexpected Transfer-Encoding in request #52575

Open
bcmills opened this issue Apr 26, 2022 · 6 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Apr 26, 2022

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestWriteTransport" && `unexpected Transfer-Encoding in request` 
2022/04/26 00:35:58 http: TLS handshake error from 127.0.0.1:38617: EOF
--- FAIL: TestRequestWriteTransport (0.59s)
    requestwrite_test.go:794: test[2]: unexpected Transfer-Encoding in request: GET / HTTP/1.1
        Host: example.com
        User-Agent: Go-http-client/1.1
        Transfer-Encoding: chunked
        Accept-Encoding: gzip
        
        0
        
FAIL
FAIL	net/http	35.584

greplogs --dashboard -md -l -e 'unexpected Transfer-Encoding in request'

2022-04-25T18:06:52-8619d3b/solaris-amd64-oraclerel
2020-01-02T20:13:03-a4c579e/darwin-arm64-mn4m2zdaios

This failure rate is uncommon and has only been observed on non-first-class ports, so leaving on the Backlog for now.

@bcmills bcmills added this to the Backlog milestone Apr 26, 2022
@bcmills bcmills added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 26, 2022
@bcmills
Copy link
Contributor Author

bcmills commented Apr 26, 2022

Expanding the regexp to other failure modes for this test does not reveal any additional failures:

greplogs --dashboard -md -l -e 'FAIL: TestRequestWriteTransport '

2022-04-25T18:06:52-8619d3b/solaris-amd64-oraclerel
2020-01-02T20:13:03-a4c579e/darwin-arm64-mn4m2zdaios

However, it could be that the test is racy in some way; see also #44088.

@bcmills
Copy link
Contributor Author

bcmills commented Nov 9, 2023

Seen again in https://build.golang.org/log/3b5be2ef32abcf753a8c0f76e646b96da61dd36d; added a watchflakes pattern.

(CC @neild)

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestWriteTransport" && `unexpected Transfer-Encoding in request` 
2023-10-12 23:27 linux-s390x-ibm go@ef6993f3 net/http.TestRequestWriteTransport (log)
--- FAIL: TestRequestWriteTransport (2.42s)
    requestwrite_test.go:794: test[1]: unexpected Transfer-Encoding in request: GET / HTTP/1.1
        Host: example.com
        User-Agent: Go-http-client/1.1
        Transfer-Encoding: chunked
        Accept-Encoding: gzip

        0

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestWriteTransport" && `unexpected Transfer-Encoding in request` 
2024-03-20 14:19 darwin-amd64-11_0 go@db423dde net/http.TestRequestWriteTransport (log)
--- FAIL: TestRequestWriteTransport (0.43s)
    requestwrite_test.go:794: test[1]: unexpected Transfer-Encoding in request: GET / HTTP/1.1
        Host: example.com
        User-Agent: Go-http-client/1.1
        Transfer-Encoding: chunked
        Accept-Encoding: gzip

        0

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestWriteTransport" && `unexpected Transfer-Encoding in request` 
2024-04-05 01:26 netbsd-arm-bsiegert go@2e064cf1 net/http.TestRequestWriteTransport (log)
--- FAIL: TestRequestWriteTransport (1.20s)
    requestwrite_test.go:794: test[2]: unexpected Transfer-Encoding in request: GET / HTTP/1.1
        Host: example.com
        User-Agent: Go-http-client/1.1
        Transfer-Encoding: chunked
        Accept-Encoding: gzip

        0

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestRequestWriteTransport" && `unexpected Transfer-Encoding in request` 
2024-05-06 21:13 linux-s390x-ibm-race go@be003bd0 net/http.TestRequestWriteTransport (log)
--- FAIL: TestRequestWriteTransport (0.98s)
    requestwrite_test.go:794: test[2]: unexpected Transfer-Encoding in request: GET / HTTP/1.1
        Host: example.com
        User-Agent: Go-http-client/1.1
        Transfer-Encoding: chunked
        Accept-Encoding: gzip

        0

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: No status
Development

No branches or pull requests

2 participants