Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: mark shape type dupok #52633

Closed
zhouguangyuan0718 opened this issue Apr 30, 2022 · 4 comments
Closed

cmd/compile: mark shape type dupok #52633

zhouguangyuan0718 opened this issue Apr 30, 2022 · 4 comments
Labels
NeedsInvestigation

Comments

@zhouguangyuan0718
Copy link
Contributor

@zhouguangyuan0718 zhouguangyuan0718 commented Apr 30, 2022

What version of Go are you using (go version)?

$ go version
go version devel go1.19-fd6c556dc8 Sat Apr 30 04:04:40 2022 +0000 linux/amd64

Does this issue reproduce with the latest release?

No, it marks all type description dupok in 1.18.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/mnt/d/01.golang/01.GOPATH/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/mnt/d/01.golang/02.playground/01.demo/playground/dwarftype/gopath/"
GOPRIVATE=""
GOPROXY="https://goproxy.cn,direct"
GOROOT="/mnt/d/01.golang/03.godev/go"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/mnt/d/01.golang/03.godev/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.19-fd6c556dc8 Sat Apr 30 04:04:40 2022 +0000"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/mnt/d/01.golang/02.playground/01.demo/playground/dwarftype/go.mod"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3478615306=/tmp/go-build -gno-record-gcc-switches"

What did you do?

go install -buildmode=shared -linkshared std

What did you expect to see?

Success.

What did you see instead?

# /tmp/go-build415098603/b236/libstd.so
2022/04/30 22:37:52 duplicated definition of symbol type.go.shape.*uint8_0, from crypto/tls and crypto/elliptic
@gopherbot
Copy link

@gopherbot gopherbot commented Apr 30, 2022

Change https://go.dev/cl/403316 mentions this issue: cmd/compile: mark shape type dupok

@dr2chase dr2chase added the NeedsInvestigation label May 3, 2022
@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented May 3, 2022

Marked it "needs investigation" to get it off the dashboard, but it is a bug, repros just fine for me, the fix looks sensible, and I pinged the likely reviewers.

@randall77
Copy link
Contributor

@randall77 randall77 commented May 3, 2022

@gopherbot please open a backport issue for 1.18.

@gopherbot
Copy link

@gopherbot gopherbot commented May 3, 2022

Backport issue(s) opened: #52687 (for 1.18).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation
Projects
None yet
Development

No branches or pull requests

4 participants