Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: update go list -m documentation for workspace mode in ref/mod #52649

Open
perillo opened this issue May 2, 2022 · 2 comments
Open

x/website: update go list -m documentation for workspace mode in ref/mod #52649

perillo opened this issue May 2, 2022 · 2 comments
Labels
Documentation GoCommand NeedsInvestigation website
Milestone

Comments

@perillo
Copy link
Contributor

@perillo perillo commented May 2, 2022

The documentation of go list -m currently says:
"If no arguments are specified, the main module is listed."

This is incorrect, since, when workspace mode is enabled, go list -m lists all the active main modules.

Here is an example:
$ go list -m -json

{
	"Path": "xxx",
	"Main": true,
	"Dir": "/tmp/src/xxx",
	"GoMod": "/tmp/src/xxx/go.mod",
	"GoVersion": "1.18"
}
{
	"Path": "yyy",
	"Main": true,
	"Dir": "/tmp/src/yyy",
	"GoMod": "/tmp/src/yyy/go.mod",
	"GoVersion": "1.18"
}
{
	"Path": "zzz",
	"Main": true,
	"Dir": "/tmp/src/zzz",
	"GoMod": "/tmp/src/zzz/go.mod",
	"GoVersion": "1.18"
}
@gopherbot gopherbot added this to the Unreleased milestone May 2, 2022
@perillo perillo changed the title x/website: update go list -m documentation for workspace in ref/mod x/website: update go list -m documentation for workspace mode in ref/mod May 2, 2022
@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented May 5, 2022

@hyangah not sure if this is yours or @dmitshur, but I this looks reasonable to me.

@dr2chase dr2chase added the NeedsInvestigation label May 5, 2022
@dmitshur
Copy link
Contributor

@dmitshur dmitshur commented May 5, 2022

Since this involves the go command's new workspace mode, I'll CC @matloob to take a look.

@dmitshur dmitshur added the GoCommand label May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation GoCommand NeedsInvestigation website
Projects
None yet
Development

No branches or pull requests

4 participants