runtime: total allocation stats are managed in a uintptr which can quickly wrap around on 32-bit architectures

[mknyszek]

A runtime failure occurs on an assertion in ReadMemStats when running the internal/intern tests. I can reproduce it locally via:

GOARCH=386 go test internal/intern

On the 386 longtest builder: https://build.golang.org/log/38f434ccb5ed0db84e99122ef69eb1f3894d7d33

Curiously, it doesn't reproduce on amd64, AFAICT.

[mknyszek]

I understand the problem. This test allocates a whole lot of memory in a loop, > 4 GiB, and memstats.heapStats.largeAlloc is unfortunately a uintptr. It really should be a uint64. It's not the only one with this problem.

It's an easy fix and we should probably backport it.

[gopherbot]

Change https://go.dev/cl/403758 mentions this issue: runtime: store consistent total allocation stats as uint64

[mknyszek]

@gopherbot Please open backport issues for Go 1.17 and Go 1.18.

[gopherbot]

Backport issue(s) opened: #52688 (for 1.17), #52689 (for 1.18).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

[gopherbot]

Change https://go.dev/cl/411495 mentions this issue: [release-branch.go1.18] runtime: store consistent total allocation stats as uint64

[gopherbot]

Change https://go.dev/cl/411494 mentions this issue: [release-branch.go1.18] runtime: store consistent total allocation stats as uint64

[gopherbot]

Change https://go.dev/cl/411496 mentions this issue: [release-branch.go1.17] runtime: store consistent total allocation stats as uint64