Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: total allocation stats are managed in a uintptr which can quickly wrap around on 32-bit architectures [1.18 backport] #52689

Open
gopherbot opened this issue May 3, 2022 · 4 comments
Labels
CherryPickApproved
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 3, 2022

@mknyszek requested issue #52680 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport issues for Go 1.17 and Go 1.18.

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 3, 2022

Basically, on 32-bit platforms, allocation stats can end up completely wrong. I'm surprised this flew under the radar for so long. There's no workaround.

@dr2chase dr2chase added the CherryPickApproved label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate label May 4, 2022
@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented May 5, 2022

Ahoy, can you do the backport CLs here? (for this and 1.17)
It may require a little cleanup work, I tried and had merge errors.
See https://github.com/golang/go/wiki/MinorReleases

@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 5, 2022

Thanks for trying David. Yeah, it's not going to be that easy because a bunch of things moved. I suspect 1.17 and 1.18 can use the same fix, but I need to basically create a separate CL for them. It'll be very similar to what landed for 1.19, but not quite the same.

@dr2chase
Copy link
Contributor

@dr2chase dr2chase commented May 5, 2022

Also not allowed to mail the cherry-pick if I do it by hand, oh well.
Some other time.

@heschi heschi removed this from the Go1.18.2 milestone May 10, 2022
@heschi heschi added this to the Go1.18.3 milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved
Projects
None yet
Development

No branches or pull requests

4 participants