Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: generic function appears to use incorrect type descriptor [1.18 backport] #52691

Closed
gopherbot opened this issue May 3, 2022 · 2 comments
Closed

cmd/compile: generic function appears to use incorrect type descriptor [1.18 backport] #52691

gopherbot opened this issue May 3, 2022 · 2 comments
Labels
CherryPickApproved
Milestone
Go1.18.2

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 3, 2022

@randall77 requested issue #52026 to be considered for backport to the next 1.18 minor release.

@gopherbot please open a backport issue for 1.18.
@gopherbot gopherbot added the CherryPickCandidate label May 3, 2022
@gopherbot gopherbot mentioned this issue May 3, 2022
Closed
@gopherbot gopherbot added this to the Go1.18.2 milestone May 3, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 3, 2022

Change https://go.dev/cl/403934 mentions this issue: [release-branch.go1.18] cmd/compile: use dictionary to convert type to shaped interface type

@dr2chase dr2chase added the CherryPickApproved label May 4, 2022
@gopherbot gopherbot removed the CherryPickCandidate label May 4, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 9, 2022

Closed by merging 500d75a to release-branch.go1.18.

gopherbot pushed a commit that referenced this issue May 9, 2022
@randall77 @heschi
[release-branch.go1.18] cmd/compile: use dictionary to convert type t…
500d75a 
…o shaped interface type

When we convert a type to a shaped interface type, we are not able
to recognize the itab. So passing the itab by dictionary as the
workaround.

Fixes #52691.

Change-Id: I75c23c7dd215daf9761dc24116a8af2c28c6d948
Reviewed-on: https://go-review.googlesource.com/c/go/+/401034
Run-TryBot: Wayne Zuo <wdvxdr@golangcn.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Keith Randall <khr@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/403934
Reviewed-by: Than McIntosh <thanm@google.com>
Run-TryBot: Keith Randall <khr@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved
Projects
None yet
Milestone
Go1.18.2
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot