Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: invalid metadata after removing recursive import #52729

Open
findleyr opened this issue May 5, 2022 · 0 comments
Open

x/tools/gopls: invalid metadata after removing recursive import #52729

findleyr opened this issue May 5, 2022 · 0 comments
Labels
gopls/metadata gopls Tools
Milestone

Comments

@findleyr
Copy link
Contributor

@findleyr findleyr commented May 5, 2022

I observed today while working on go/types: my package was broken due to a trivial recursive import: goimports inserted an import of go/types in methodset.go because I typed types.<...> rather than just <...>. Goimports shouldn't do that, but independently when I removed the import, the go list errors persisted.

Looks like a metadata invalidation bug.

@findleyr findleyr added the gopls/metadata label May 5, 2022
@findleyr findleyr added this to the gopls/on-deck milestone May 5, 2022
@gopherbot gopherbot added Tools gopls labels May 5, 2022
@findleyr findleyr added this to Backlog in Gopls Backlog May 10, 2022
@findleyr findleyr removed this from Backlog in Gopls Backlog May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/metadata gopls Tools
Projects
None yet
Development

No branches or pull requests

2 participants