Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: TestGcSys is still flaky [1.17 backport] #52826

Closed
gopherbot opened this issue May 10, 2022 · 3 comments
Closed

runtime: TestGcSys is still flaky [1.17 backport] #52826

gopherbot opened this issue May 10, 2022 · 3 comments
Labels
CherryPickApproved release-blocker Testing
Milestone

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented May 10, 2022

@bcmills requested issue #37331 to be considered for backport to the next 1.17 minor release.

@gopherbot, please backport to Go 1.17. This test is skipped on the main branch, but still failing semi-regularly on the release branch.

@gopherbot gopherbot added the CherryPickCandidate label May 10, 2022
@gopherbot gopherbot added this to the Go1.17.10 milestone May 10, 2022
@bcmills bcmills added Testing release-blocker labels May 10, 2022
@heschi heschi removed this from the Go1.17.10 milestone May 10, 2022
@heschi heschi added this to the Go1.17.11 milestone May 10, 2022
@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 18, 2022

Change https://go.dev/cl/406974 mentions this issue: [release-branch.go1.17] runtime: mark TestGcSys as flaky

@mknyszek mknyszek added the CherryPickApproved label May 18, 2022
@gopherbot gopherbot removed the CherryPickCandidate label May 18, 2022
@mknyszek
Copy link
Contributor

@mknyszek mknyszek commented May 18, 2022

This is just a testing skip that improves release builder stability.

@gopherbot
Copy link
Author

@gopherbot gopherbot commented May 18, 2022

Closed by merging 0e7138a to release-branch.go1.17.

gopherbot pushed a commit that referenced this issue May 18, 2022
I don't know what this test is doing, but it very frequently flakes
for me while testing mundane compiler CLs. According to the issue log,
it's been flaky for ~3 years.

Updates #37331.
Fixes #52826.

Change-Id: I81c43ad646ee12d4c6561290a54e4bf637695bc6
Reviewed-on: https://go-review.googlesource.com/c/go/+/336349
Trust: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
(cherry picked from commit d8ceb13)
Reviewed-on: https://go-review.googlesource.com/c/go/+/406974
Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved release-blocker Testing
Projects
None yet
Development

No branches or pull requests

4 participants