testing: t.Parallel should pause test timer while it waits

The function t.Parallel() does not pause the internal timer, so the time that it takes
for the test case to get scheduled gets counted in that test's execution time. 

Options:
1) This can be fixed by moving the StopTimer stuff from testing.B to testing.common, and
using those functions inside t.Parallel to stop the timer before doing the chan ops, and
starting the timer again afterwards.

2) Manually pause and resume the timer by messing around with the start time in
t.Parallel

Comment 1:

I can write the fix, but I suspect it is too close to 1.1 to be accepted anyways. 
Either way, let me know which option is preferred so that when 1.1 is out, I can write
and send in a CR (if someone doesn't beat me to it).

Comment 2:

I suggest this is a post 1.1 issue. IMO t.Parallel is not commonly used.

Labels changed: added priority-later, removed priority-triage.

Status changed to HelpWanted.

Comment 3:

Labels changed: added suggested, go1.2maybe.

Status changed to Accepted.

@robpike

Comment 4:

Owner changed to @robpike.

Status changed to Started.

Comment 5:

This issue was closed by revision 6fb9cc1.

Status changed to Fixed.

Navigation Menu

Repository navigation

testing: t.Parallel should pause test timer while it waits #5285

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

testing: t.Parallel should pause test timer while it waits #5285

Description

Activity

balasanjay commented on Apr 13, 2013

davecheney commented on Apr 13, 2013

rsc commented on Jul 30, 2013

robpike commented on Aug 16, 2013

robpike commented on Aug 19, 2013

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions