Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build, crypto/x509: macOS flakes due to "certificate is not standards compliant" #52854

Closed
neild opened this issue May 11, 2022 · 4 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Milestone

Comments

@neild
Copy link
Contributor

neild commented May 11, 2022

Splitting the builder flakiness off from #51991.

#51991 (comment)

@bcmills

This is showing up on the darwin-amd64-10_15 builder as well, though curiously not on any of the other darwin builders.

Marking as release-blocker for Go 1.19 because darwin/amd64 is a first class port.

greplogs --dashboard -md -l -e 'certificate is not standards compliant'

2022-04-19T23:20:21-8b900b4-104742f/darwin-amd64-10_15
2022-04-14T22:52:29-7bdebbc-cc43e19/darwin-amd64-10_15
2022-01-20T14:59:17-3ed4219-9284279/darwin-amd64-10_15
2022-01-19T15:34:05-a71de3f-ca33b34/darwin-amd64-10_15
2022-01-18T23:19:04-03fcf44-626f13d/darwin-amd64-10_15
2022-01-18T21:43:02-8066ee9-cf5d73e/darwin-amd64-10_15
2022-01-13T21:34:46-4e31bde-6891d07/darwin-amd64-10_15
2022-01-13T20:43:56-03fcf44-6891d07/darwin-amd64-10_15
2022-01-11T16:48:27-62f0361-1cc3c73/darwin-amd64-10_15
2022-01-06T17:36:12-b511507-f009910/darwin-amd64-10_15
2021-12-15T23:51:57-598f1b0-6e7c691/darwin-amd64-10_15
2021-12-15T00:33:55-18bc0f9-9d0ca26/darwin-amd64-10_15
2021-12-13T18:48:44-d71ffde-2580d0e/darwin-amd64-10_15

@rolandshoemaker

As far as I can tell this seems, possibly, (this is unbearably painful to diagnose) to be an issue with 10.15.1, which is what the the darwin-amd64-10_15 builder is running. I suspect that updating the builder to use 10.15.6 would fix this, but I have absolutely no clue how viable that is.

@neild neild added release-blocker OS-Darwin NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels May 11, 2022
@neild neild added this to the Go1.19 milestone May 11, 2022
@dmitshur dmitshur added the Builders x/build issues (builders, bots, dashboards) label May 11, 2022
@dmitshur dmitshur changed the title crypto/x509: macOS flakes due to "certificate is not standards compliant" x/build, crypto/x509: macOS flakes due to "certificate is not standards compliant" May 31, 2022
@dmitshur dmitshur added this to In Progress in Go Release Team May 31, 2022
@heschi
Copy link
Contributor

heschi commented Jun 2, 2022

As of a couple minutes ago the builders are updated to 10.15.7.

@heschi heschi removed their assignment Jun 2, 2022
@heschi heschi moved this from In Progress to Done in Go Release Team Jun 2, 2022
@heschi
Copy link
Contributor

heschi commented Jun 3, 2022

This is currently marked beta-blocking, but I think the only possible action is to wait a while and and see if it recurs. Given that we're trying to get the beta out pretty soon, I guess let's wait for a few days, check again, and then mark it okay after beta1?

@bcmills
Copy link
Member

bcmills commented Jun 3, 2022

Now that we're in the freeze I doubt we'll get enough test runs on this builder to provide much data one way or the other.

I think it would be fine to go ahead and close it as “probably fixed” (since we don't know of anything more to do about it right now), and we can reopen it and update the milestone if/when it recurs again.

@heschi
Copy link
Contributor

heschi commented Jun 3, 2022

OK, let's do that then.

@heschi heschi closed this as completed Jun 3, 2022
@golang golang locked and limited conversation to collaborators Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin release-blocker
Projects
Archived in project
Development

No branches or pull requests

5 participants