Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Imported by reports 0 in error #52872

Closed
wxolp opened this issue May 12, 2022 · 3 comments
Closed

x/pkgsite: Imported by reports 0 in error #52872

wxolp opened this issue May 12, 2022 · 3 comments
Labels
NeedsInvestigation pkgsite

Comments

@wxolp
Copy link

@wxolp wxolp commented May 12, 2022

What is the URL of the page with the issue?

https://pkg.go.dev/github.com/edgeware/mp4ff/mp4

What is your user agent?

None of your business

Screenshot

No

What did you do?

Just go to that page

What did you expect to see?

If you go here:

https://pkg.go.dev/github.com/edgeware/mp4ff/mp4?tab=importedby

youll see that it is imported by other stuff.

What did you see instead?

Imported by: 0
@wxolp wxolp added the pkgsite label May 12, 2022
@gopherbot gopherbot added this to the pkgsite/unplanned milestone May 12, 2022
@jamalc jamalc added the NeedsInvestigation label May 13, 2022
@jamalc
Copy link

@jamalc jamalc commented May 13, 2022

GetImportedBy and GetImportCount are the relevant code paths here. I see two issues. GetImportedBy is version unaware and GetImportCount only returns the count for latest version (versions available in the search documents table). Compare v0.28.0 and v0.27.0 on deps.dev.

/cc @jba

@jba
Copy link
Contributor

@jba jba commented May 16, 2022

We think we understand the problem and we have a fix. We'll update here when it's ready.

@jba
Copy link
Contributor

@jba jba commented May 18, 2022

This is fixed in production.

@jba jba closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants